Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retain autorun setup upon updates #237

Merged
merged 4 commits into from Oct 12, 2021
Merged

Conversation

sarathms
Copy link
Contributor

@sarathms sarathms commented Jul 28, 2021

Fix ooni/probe#1464

  • Drop using the .first-run file that was being removed during an update causing autorun settings to reset to defaults (disabled)
  • Check for autorun files (.plist, .bat, .vbs) upon startup and regenerate them if missing, without changing the autorun status
  • Get the autorun status from the scheduler instead of using the settings store

@sarathms sarathms requested a review from hellais July 28, 2021 13:28
Copy link
Member

@hellais hellais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sarathms sarathms force-pushed the fix/autorun-config-onupdate branch from 2e603d7 to a80d0d0 Compare August 9, 2021 16:33
@hellais
Copy link
Member

hellais commented Oct 12, 2021

@sarathms what's the status of this? Can you look into merging it?

@sarathms
Copy link
Contributor Author

I rebased this branch with master after the E2E tests were then merged. Turns out the test code has a bug which doesn't handle well cases where the app launches the About window first instead of the main window e.g when there is a auto-update related notice to be shown at launch.

I think we should go ahead and merge this PR because it was already tested manually and no other changes were made during the rebase itself. I will fix the test code separately.

@sarathms sarathms merged commit ac5c2bf into master Oct 12, 2021
@sarathms sarathms deleted the fix/autorun-config-onupdate branch October 12, 2021 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants