Implement skeleton for Test Details Views #44
Conversation
sarathms
added this to In Progress
in DO NOT USE (was: OONI Probe Desktop)
via automation
|
As of now, we have a working structure. Specific data like the content for Hero (and an alternative collapsed Hero), test details come from its own Also added a collection called @hellais Please review and point out holes in this approach.
|
I took a look at the code as well and this approach looks solid to me 👍 |
|
Is it useful if I make a mockup of how the views in collapsed vs expanded form shall look like? |
sarathms
changed the title
|
I suggest to merge this PR and then follow up with others! |
|
I had made some changes to the approved model because I immediately found a problem with it. I will send them for review here in the next few minutes. |
|
The latest commit helps compose a few common UI elements in the Hero (like Test Name, Date, Network) in the Container component, instead of all the test specific components. This also prevents having to pass in the
|
| @@ -89,6 +91,24 @@ export const testGroups = { | |||
| } | |||
| } | |||
|
|
|||
| export const tests = { | |||
| web_connectivity, | |||
There was a problem hiding this comment.
This is syntactic sugar for web_connectivity: web_connectivity, right?
| return ( | ||
| <div> | ||
| {render({ | ||
| heroBG: 'green8', // TODO: Determine color based on presence of anomaly |
There was a problem hiding this comment.
Suggested // TODO(sarathms): ... so we know who's owning the TODO
| whatsapp: web_connectivity, | ||
| ndt: web_connectivity, | ||
| dash: web_connectivity, | ||
| vanilla_tor: web_connectivity, |
There was a problem hiding this comment.
If your goal is to later replace each of them, please add a TODO(sarathms): ... comment to indicate that.
| @@ -97,32 +99,144 @@ const HeaderContent = styled(Box)` | |||
| -webkit-app-region: drag; | |||
| ` | |||
|
|
|||
| const detailsMap = { | |||
| web_connectivity: WebConnectivity, | |||
| facebook_messenger: FacebookMessengerDetails | |||
There was a problem hiding this comment.
Does this mean that more will come later? If so, please add a // TODO(sarathms): ... comment to say that
Implements 1 out of 7 views listed in #3