Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide results for incomplete tests #92

Merged
merged 2 commits into from Dec 23, 2019
Merged

Hide results for incomplete tests #92

merged 2 commits into from Dec 23, 2019

Conversation

sarathms
Copy link
Contributor

Fixes #48

@sarathms sarathms self-assigned this Dec 16, 2019
@hellais hellais added this to the Sprint 2 milestone Dec 18, 2019
@hellais
Copy link
Member

hellais commented Dec 23, 2019

This looks good to me.

We may want to eventually still show the results which are partial so that the user is able to do the cleanup of the results.

For the moment, though I think this is good.

@hellais hellais closed this Dec 23, 2019
@hellais hellais reopened this Dec 23, 2019
hellais
hellais approved these changes Dec 23, 2019
View reviewed changes
Copy link
Member

@hellais hellais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filed another issue for some future work, but otherwise good to merge.

@hellais hellais merged commit 33108df into master Dec 23, 2019
@hellais hellais mentioned this pull request Jan 13, 2020
Closed
@hellais hellais deleted the fix/incomplete-results-crash branch March 6, 2020 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hellais hellais hellais approved these changes

Assignees

@sarathms sarathms

Labels
None yet
Projects
None yet
Milestone
Sprint 2 - Cuttlefish
2 participants
@sarathms @hellais