Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

psiphon: follow-up of using config from orchestra #168

Closed
4 tasks done
bassosimone opened this issue Dec 10, 2019 · 0 comments · Fixed by #180
Closed
4 tasks done

psiphon: follow-up of using config from orchestra #168

bassosimone opened this issue Dec 10, 2019 · 0 comments · Fixed by #180
Assignees
@bassosimone
Labels
effort/S Small effort priority/high High priority
Milestone
Sprint 2 - Cuttle...

Comments

@bassosimone
Copy link
Contributor

bassosimone commented Dec 10, 2019 •
edited
Loading

Once we use the config from orchestra as described in #167, we don't need to ship an encrypted Psiphon config file for running integration testing. This greatly simplifies the job of running unit tests for anyone who's not core team, and makes the -tags nopsiphon tag unnecessary.

This is the list of cleanups unlocked by #167:

  • stop shipping encrypted config file
  • simplify .travis.yml
  • remove support for -tags nopsiphon
  • stop mentioning such flag in CONTRIBUTING.md

All of this should be quick and easy.
@bassosimone bassosimone added priority/high High priority effort/S Small effort labels Dec 10, 2019
@bassosimone bassosimone mentioned this issue Dec 10, 2019
Closed
14 tasks
@bassosimone bassosimone self-assigned this Dec 10, 2019
@bassosimone bassosimone changed the title psiphon: follow-up of fetching config from orchestra psiphon: follow-up of using config from orchestra Dec 16, 2019
bassosimone added a commit that referenced this issue Dec 18, 2019
@bassosimone
psiphon: simplify now that we get config from orchestra
820c5c5 
Closes #168
@bassosimone bassosimone mentioned this issue Dec 18, 2019
Merged
bassosimone added a commit that referenced this issue Dec 18, 2019
@bassosimone
psiphon: simplify now that we get config from orchestra (#180)
acf88ff 
* psiphon: simplify now that we get config from orchestra

Closes #168

* Remove error we don't use anymore

* ouch, forgot to run tests locally

(I am on a 4G connection with bad SNR and few gigas left, so I am less
inclined than usual to running tests locally)

* oops 2
@hellais hellais added this to the Sprint 2 - Cuttlefish milestone Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bassosimone bassosimone

Labels
effort/S Small effort priority/high High priority
Projects
None yet
Milestone
Sprint 2 - Cuttlefish
Development

Successfully merging a pull request may close this issue.

psiphon: simplify now that we get config from orchestra ooni/probe-engine
2 participants
@bassosimone @hellais