Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dash: rewrite using github.com/neubot/dash #51

Closed
2 tasks
bassosimone opened this issue Sep 10, 2019 · 0 comments · Fixed by #61
Closed
2 tasks

dash: rewrite using github.com/neubot/dash #51

bassosimone opened this issue Sep 10, 2019 · 0 comments · Fixed by #61
Labels
enhancement New feature or request
Projects
DO NOT USE (was: OONI Nettests and En...

Comments

@bassosimone
Copy link
Contributor

bassosimone commented Sep 10, 2019 •
edited
Loading

I've recently written a Go implementation of Neubot's DASH test at github.com/neubot/dash. This issue is about performing the following tasks:

  • replace the current implementation with code calling github.com/neubot/dash directly

  • make sure that the resulting JSON is consistent with what you obtain using MK and, if not, take the proper actions to make sure it becomes consistent
@bassosimone bassosimone added help wanted new experiment Implementation of a new experiment labels Sep 10, 2019
@bassosimone bassosimone added this to Backlog in DO NOT USE (was: OONI Nettests and Engine) via automation Sep 10, 2019
@bassosimone bassosimone added P2 enhancement New feature or request and removed P2 new experiment Implementation of a new experiment labels Sep 10, 2019
@bassosimone bassosimone added this to the v0.1.0 milestone Sep 12, 2019
xhdix added a commit to xhdix/probe-engine that referenced this issue Sep 13, 2019
@xhdix
dash: rewrite using neubot/dash
654163a 
close ooni#51
@xhdix xhdix mentioned this issue Sep 13, 2019
Merged
xhdix added a commit to xhdix/probe-engine that referenced this issue Sep 13, 2019
@xhdix
dash: rewrite using neubot/dash
5193f3d 
close ooni#51
xhdix added a commit to xhdix/probe-engine that referenced this issue Sep 14, 2019
@xhdix
dash: rewrite using neubot/dash
6724e67 
close ooni#51
@bassosimone bassosimone removed this from the v0.1.0 milestone Sep 23, 2019
@bassosimone bassosimone modified the milestones: new-nettests, new-experiments-otfy2 Oct 2, 2019
xhdix added a commit to xhdix/probe-engine that referenced this issue Oct 7, 2019
@xhdix
# This is a combination of 2 commits.
6aa500f 
# This is the 1st commit message:

dash: rewrite using neubot/dash

close ooni#51

# The commit message #2 will be skipped:

#	separate Go and C code
xhdix added a commit to xhdix/probe-engine that referenced this issue Oct 7, 2019
@xhdix
dash: rewrite using neubot/dash
84fb78b 
close ooni#51
xhdix added a commit to xhdix/probe-engine that referenced this issue Oct 7, 2019
@xhdix
dash: rewrite using neubot/dash and separate Go and C code
fc5ef9c 
close ooni#51
xhdix added a commit to xhdix/probe-engine that referenced this issue Oct 7, 2019
@xhdix
dash: rewrite using neubot/dash and separate Go and C code
58f057f 
close ooni#51
xhdix added a commit to xhdix/probe-engine that referenced this issue Oct 7, 2019
@xhdix
dash: rewrite using neubot/dash and separate Go and C code
7d3dcf4 
close ooni#51
@bassosimone bassosimone mentioned this issue Oct 7, 2019
Closed
6 tasks
xhdix added a commit to xhdix/probe-engine that referenced this issue Oct 7, 2019
@xhdix
dash: rewrite using neubot/dash and separate Go and C code
c555b29 
close ooni#51
xhdix added a commit to xhdix/probe-engine that referenced this issue Oct 7, 2019
@xhdix
dash: rewrite using neubot/dash and separate Go and C code
271d5e0 
close ooni#51
DO NOT USE (was: OONI Nettests and Engine) automation moved this from Backlog to Done Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
No open projects
DO NOT USE (was: OONI Nettests and En...
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

dash: rewrite using neubot/dash xhdix/probe-engine
2 participants
@bassosimone @hellais