Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

regression: telegram not correctly setting TCP blocking #827

Closed
bassosimone opened this issue Jul 23, 2020 · 0 comments
Closed

regression: telegram not correctly setting TCP blocking #827

bassosimone opened this issue Jul 23, 2020 · 0 comments
Assignees
@bassosimone
Labels
bug Something isn't working
Milestone
Sprint 18 - Colomber

Comments

@bassosimone
Copy link
Member

Spotted during #826 when integrating Jafar's QA.

This is how the build failed:

Traceback (most recent call last):
  File "./QA/telegram/telegram.py", line 320, in <module>
    main()
  File "./QA/telegram/telegram.py", line 315, in main
    test(ooni_exe, outfile)
  File "./QA/telegram/telegram.py", line 162, in telegram_block_everything
    assert tk["telegram_tcp_blocking"] == True
AssertionError

I will fix this issue as part of the same PR.
@bassosimone bassosimone added the bug Something isn't working label Jul 23, 2020
@bassosimone bassosimone self-assigned this Jul 23, 2020
bassosimone added a commit that referenced this issue Jul 23, 2020
@bassosimone
fix(telegram): make sure tcp blocking is computed correctly
9c19169 
Closes #827

Part of #356
bassosimone added a commit that referenced this issue Jul 23, 2020
@bassosimone
fix(telegram): make sure tcp blocking is computed correctly
4daad62 
Closes #827

Part of #356

Part of #828
@bassosimone bassosimone added this to the Sprint 18 - Colomber milestone Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bassosimone bassosimone

Labels
bug Something isn't working
Projects
None yet
Milestone
Sprint 18 - Colomber
Development

No branches or pull requests
1 participant
@bassosimone