fix: use example.org rather than example.com #1040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that example.org is a more reliable helper.
bassosimone
added a commit
to ooni/spec
that referenced
this pull request
Nov 12, 2020
The spec should not say that the experiment will use a specific domain name since that's clearly too binding. Let us instead just use example.org as an example and let us the experiment be free to update the real helper depending on its needs. This change opens up the opportunity of dynamically provisioning the real helper to the probes depending on the country and on other factors. Related PR: ooni/probe-engine#1040 Work done in the context of: ooni/probe-engine#622
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that example.org is a more reliable helper.
Related spec change: ooni/spec@1d30004
Work done in the context of: #622