fix(dnscheck): avoid false positive due to timeout #1160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. avoid setting a unique timeout for the whole measurement 2. set a 20 seconds timeout for the bootstrap 3. use up to 10 concurrent goroutines for the lookups 4. set a 45 seconds timeout for each individual lookup 5. urlgetter/getter.go: introduce a timeout (for now do not expose it to command line since that is more work) 6. urlgetter/urlgetter.go: use the new timeout in getter.go 7. urlgetter/getter.go: add tests for the timeout case See #1159
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
avoid setting a unique timeout for the whole measurement
set a 20 seconds timeout for the bootstrap
use up to 10 concurrent goroutines for the lookups
set a 45 seconds timeout for each individual lookup
urlgetter/getter.go: introduce a timeout (for now do not
expose it to command line since that is more work)
urlgetter/urlgetter.go: use the new timeout in getter.go
urlgetter/getter.go: add tests for the timeout case
See #1159