Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set of changes to unblock ooni/probe-cli#46 #37

Merged
merged 4 commits into from
Aug 14, 2019

Commits on Aug 13, 2019

  1. measurementkit.go: disable resolver lookup

    This is currently speculative, since MK v0.10.5 has not been
    released yet. Nonetheless, this functionality should be working
    when we have relased that version.
    bassosimone committed Aug 13, 2019
    Configuration menu
    Copy the full SHA
    7826c03 View commit details
    Browse the repository at this point in the history
  2. go.mod: update direct dependencies except psiphon

    Psiphon is not using `go.mod`. Updating also psiphon should be
    done with extra care precisely because of that.
    
    For other dependencies, we can go YOLO.
    bassosimone committed Aug 13, 2019
    Configuration menu
    Copy the full SHA
    caf6b0d View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2019

  1. collector: implement scrubbing safety net

    This diff introduces code to redact IP, ASN, and CC directly
    in the engine, rather than delegating doing that.
    
    When you initialise a Session, it's your responsibility to
    change the default privacy settings.
    
    The names of the collector.PrivacySettings structure fields
    are the same names used by ooni/probe-cli.
    
    After a measurement, the settings configured in the session are
    honoured with respect to redacting IP, ASN, and CC.
    
    We take an extra step of redacting the whole test keys
    string, _if_ it contains the IP.
    
    This is an extra safety net to make sure that we are really
    scrubbing the body. The nettest should do that.
    
    This commit is part of #28.
    bassosimone committed Aug 14, 2019
    Configuration menu
    Copy the full SHA
    1d12804 View commit details
    Browse the repository at this point in the history
  2. collector: make code more correct and compact

    1. make sure we use a separate structure for the open report response
    such that the server cannot write our data structure
    
    2. make sure symbols that can be private are actually private
    
    3. make sure the code is compliant with the spec by checking that
    the server actually supports `json` reports
    bassosimone committed Aug 14, 2019
    Configuration menu
    Copy the full SHA
    861ff03 View commit details
    Browse the repository at this point in the history