Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for passing the limit and category code to the testlists pkg #39

Merged
merged 3 commits into from Aug 23, 2019

Conversation

hellais
Copy link
Member

@hellais hellais commented Aug 15, 2019

This is useful so that we can better configure the testing targets.

It's especially important since now the backend will return the full test list by default.

Copy link
Member

@bassosimone bassosimone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check why testa are failing? I did a first pass at reading the code and am very pleased by this diff otherwise.

@hellais
Copy link
Member Author

hellais commented Aug 16, 2019

Yeah my bad, the tests were not passing for a good reason.

It should now be fixed.

@bassosimone
Copy link
Member

Did a second reading and left one single, minor comment.

@bassosimone bassosimone merged commit 49134e5 into master Aug 23, 2019
@bassosimone bassosimone deleted the orchestra-test-lists branch August 23, 2019 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants