jsonapi, probeservices: refactoring before detecting blocking #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of ooni/probe#887. I determined that we needed some refactoring of jsonapi before proceeding.
There is no reason in doing so. Mutable state leads to code that is more difficult to analyse, hence, let's just do that. Part of the refactoring that I determined was necessary before moving ooni/probe#887 forward.
Closes #270 Part of the refactoring that I think it's necessary to do before moving ooni/probe#887 forward.
This is part of ooni/probe#887 where I determined that we needed to do some refactoring of jsonapi. Specifically, here the goal is to avoid using magic functions as well as to make sure tests check the properties we care about.
Instead, use embedding, so that we don't need to write tests asserting that we pass downstream the correct fields. Somewhere else (session? experiment?) we probably need to put more tests, but at least here's one less middleman. Part of the refactoring that I started such that it is easy to do ooni/probe#887.
Keep returning a pointer in OpenReport. Apart from that, do not return pointers and make sure structures cannot change themselves. This should conclude the preliminary refactoring that I envisioned before doing ooni/probe#887.
|
Merging! (The failure seems to be a false positive and also tests pass locally) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a but of unrelated diffs that perform refactoring of jsonapi and probeservices. I want these changes to be in before continuing with ooni/probe#887.