Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #114 #115

Closed
wants to merge 1 commit into from
Closed

Fix #114 #115

wants to merge 1 commit into from

Conversation

tsekityam
Copy link

[tampering objectForKey:@"xxx"] can be NSNull object. As a result, we have to check null before accessing the bool value or the app may crash.

@tsekityam
Fix #114
beafcb5 
`[tampering objectForKey:@"xxx"]` can be `NSNull` object. As a result, we have to check null before accessing the bool value or the app may crash.
@bassosimone
Copy link
Member

Thanks! We'll include this diff in the next release.

@hellais
Copy link
Member

hellais commented Jul 8, 2017

@bassosimone see: https://github.com/TheTorProject/ooniprobe-ios/issues/114#issuecomment-313875399

@bassosimone
Copy link
Member

@hellais Thanks, I just saw it.

@tsekityam
Copy link
Author

already fixed at 02ca808

@tsekityam tsekityam closed this Jul 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bassosimone bassosimone bassosimone approved these changes

Assignees

@lorenzoPrimi lorenzoPrimi

Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@tsekityam @bassosimone @hellais @lorenzoPrimi