Feature/upload result manually #258
Conversation
Test methodology
|
|
||
| @interface UploadFooterViewController () | ||
|
|
||
| @end |
There was a problem hiding this comment.
Is this empty interface needed?
There was a problem hiding this comment.
This is the xcode generated file. I never touch it.
There was a problem hiding this comment.
I feel brave today :-). Can you please remove it? I'm sure I've written ObjectiveC code where this internal interface was not there, so we can safely remove it.
There was a problem hiding this comment.
Removing it still builds the project.
The fact is this interface is in basically every file so maybe is better to have a PR with a general cleanup rather than doing it only once in one file
There was a problem hiding this comment.
Let's start with not increasing the entropy in this PR. Refactoring other files can be done incrementally.
("Always leave the camp cleaner than you find it.")
There was a problem hiding this comment.
so do you think this can be refactored here or in a next PR?
There was a problem hiding this comment.
Just remove the three lines in this file, so we don't ever commit them. We'll deal with the rest with time and calm as there is no rush to convert all the code base today, just the desired to make this PR minimal.
|
@lorenzoPrimi please, address the remaining comments. Then, I'll do a final pass. |
Fixes ooni/probe#838
TestSummaryTableViewController.m became TestSummaryViewController.m but for some reason git think is a new file