Implement faster measurement resubmission #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of ooni/probe#861. Uses measurement-kit/mkcollector#25 and measurement-kit/mkall-ios#25 to make the act of resubmitting really faster. This is bundled with https://github.com/measurement-kit/mkall-ios/releases/tag/v0.5.5 that contains also reliability fixes, including a fix to make sure we really deallocate ObjectiveC objects context.
|
@lorenzoPrimi please take a look |
8 tasks
|
@lorenzoPrimi there is a branch and PR of the iOS app that you can use for this purpose |
|
@lorenzoPrimi updated to use mkall-ios v0.6.0 (and MK v0.10.5). Please, take a look! |
lorenzoPrimi
approved these changes
Aug 23, 2019
|
As discussed with @lorenzoPrimi, I'll leave to merge this PR when it's most convenient for him! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of ooni/probe#861.
Uses measurement-kit/mkcollector#25 and measurement-kit/mkall-ios#25 to make the act of resubmitting really faster.
This is bundled with https://github.com/measurement-kit/mkall-ios/releases/tag/v0.5.5 that contains also reliability fixes, including a fix to make sure we really deallocate ObjectiveC objects context.