Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positive for whatsapp web blocking in whatsapp test #60

Open
hellais opened this issue Oct 14, 2019 · 3 comments · May be fixed by #61
Open

False positive for whatsapp web blocking in whatsapp test #60

hellais opened this issue Oct 14, 2019 · 3 comments · May be fixed by #61
Labels
bug Something isn't working priority/medium

Comments

@hellais
Copy link
Member

hellais commented Oct 14, 2019

The WhatsApp test in probe-legacy does not pass the correct user-agent headers when performing a the HTTP requests to web.telegram.com, as a result the requests get redirected to https://www.whatsapp.com/unsupportedbrowser.

This has started happening fairly recently and can be seen in these measurements: https://explorer.ooni.org/measurement/20191012T050117Z_AS27738_cPgVPawG2ov0PE3tY6oBBOoDAvLEttflXtPGaA2md8NfcxrjeP.

The issue is not present in later versions of OONI Probe that use measurement-kit or probe-engine.

Consumers of the whatsapp measurement results should consider a redirect as part of the TLS request to https://web.whatsapp.com/ to https://www.whatsapp.com/unsupportedbrowser as a valid response and not trigger the blocked heuristics.

@hellais hellais added the bug Something isn't working label Oct 14, 2019
@hellais
Copy link
Member Author

hellais commented Oct 14, 2019

For reference by doing the following we are able to get valid whatsapp results: #61.

@hellais hellais linked a pull request Oct 14, 2019 that will close this issue
@bassosimone bassosimone self-assigned this Dec 23, 2019
@bassosimone
Copy link
Contributor

I will make sure this lands.

@bassosimone
Copy link
Contributor

As discussed with @hellais, we're not fixing this issue but leaving it open for documentation purposes. As such, I am going to remove myself as an assignee.

@bassosimone bassosimone removed their assignment Feb 13, 2020
@hellais hellais removed the effort/S label Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority/medium
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants