Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement MVP of automatic testing for windows #1053

Closed
hellais opened this issue Mar 13, 2020 · 4 comments
Closed

Implement MVP of automatic testing for windows #1053

hellais opened this issue Mar 13, 2020 · 4 comments
Assignees
@sarathms
Labels
discuss invites discussion from contributors ooni/probe-desktop platform/windows priority/medium
Milestone
Sprint 28 - Coral...

Comments

@hellais
Copy link
Member

hellais commented Mar 13, 2020

No description provided.

@hellais hellais added this to the Sprint 16 - Neon milestone Jun 8, 2020
@hellais
Copy link
Member Author

hellais commented Jul 20, 2020

See also the research I did on this here: https://docs.google.com/document/d/1baCWl-mPNlcOkth7Ap-SrukQUKMJ5Rqb7fMM5i0ekiM/edit#heading=h.83pd7oav038d

@hellais hellais added the discuss invites discussion from contributors label Nov 25, 2020
@sarathms
Copy link

sarathms commented Dec 16, 2020 •
edited

Look into uninstallation flow. The scheduled tasks should be deleted during uninstallation.

@sarathms
Copy link

sarathms commented Dec 16, 2020 •
edited

On Windows, the a custom Uninstall script can be written. As per docs. Here are some examples:
electron-userland/electron-builder#4141 (comment)
electron-userland/electron-builder#3585 (comment)
electron-userland/electron-builder#3128 (comment)

@sarathms
Copy link

The proof of conect was implemented on Windows with Electron Fiddle using the below gist.
https://gist.github.com/sarathms/b5bf3dbaee58080086ffa7a7045dec8b

We will be implementing something similar in a cross platform manner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sarathms sarathms

Labels
discuss invites discussion from contributors ooni/probe-desktop platform/windows priority/medium
Projects
None yet
Milestone
Sprint 28 - Corallimorpharia
Development

No branches or pull requests
3 participants
@bassosimone @hellais @sarathms