Fix bug that displays inconsistent results between Test Results view and measurement pages

[agrabeli]

A community member reported that when they tested websites with OONI Probe Desktop, a certain site (bagongalyansangmakabayan.org) was annotated as Likely blocked in the Test Results view:

However, when they clicked on that test result, the measurement page indicated that the tested website was accessible:

This suggests that there is a bug in how results are annotated in the Test Results view of OONI Probe Desktop.

[marilou000]

Hi Maria, Hi Maja, clarifying the test result I had in OONI desktop:

• The first screenshot is taken from Mac and the second one is taken from Windows.
• I am using same connection (AS9299) but got different result: On Mac, likely blocked by means of DNS tampering. However in Windows, it says it is accessible.

[agrabeli]

Thank you @marilou000 for the clarification. Would it perhaps be possible to share the measurements pertaining to each (so that we can inspect the data)?

You can access each measurement by clicking the "Show in OONI Explorer" button in each measurement page.

Thanks. <3

[marilou000]

Thanks Maria!

Here is the data from Mac:

{
"annotations": {
"architecture": "amd64",
"engine_name": "ooniprobe-engine",
"engine_version": "3.14.1",
"platform": "macos"
},
"data_format_version": "0.2.0",
"input": "https://bagongalyansangmakabayan.org/",
"measurement_start_time": "2022-06-23 08:48:16",
"probe_asn": "AS9299",
"probe_cc": "PH",
"probe_ip": "127.0.0.1",
"probe_network_name": "Philippine Long Distance Telephone Co.",
"report_id": "",
"resolver_asn": "AS13335",
"resolver_ip": "162.158.229.16",
"resolver_network_name": "Cloudflare, Inc.",
"software_name": "ooniprobe-desktop",
"software_version": "3.7.0",
"test_keys": {
"accessible": false,
"agent": "redirect",
"blocking": "dns",
"body_length_match": null,
"body_proportion": 0,
"client_resolver": "162.158.229.16",
"control": {
"dns": {
"addrs": [],
"failure": "unknown_error"
},
"http_request": {
"body_length": 62242,
"failure": null,
"headers": {
"Alt-Svc": "h3=":443"; ma=2592000, h3-29=":443"; ma=2592000, h3-Q050=":443"; ma=2592000, h3-Q046=":443"; ma=2592000, h3-Q043=":443"; ma=2592000, quic=":443"; ma=2592000; v="43,46"",
"Content-Type": "text/html; charset=UTF-8",
"Date": "Thu, 23 Jun 2022 08:48:15 GMT",
"Link": "https://bagongalyansangmakabayan.org/wp-json/; rel="https://api.w.org/\"",
"Server": "LiteSpeed",
"Strict-Transport-Security": "max-age=63072000; includeSubDomains",
"X-Content-Type-Options": "nosniff",
"X-Frame-Options": "SAMEORIGIN",
"X-Powered-By": "PHP/7.4.30"
},
"status_code": 200,
"title": "Bagong alyansang makabayan"
},
"tcp_connect": {}
},
"control_failure": null,
"dns_consistency": "inconsistent",
"dns_experiment_failure": "dns_nxdomain_error",
"headers_match": null,
"http_experiment_failure": null,
"network_events": null,
"queries": [
{
"answers": null,
"engine": "system",
"failure": "dns_nxdomain_error",
"hostname": "bagongalyansangmakabayan.org",
"query_type": "A",
"resolver_address": "",
"resolver_hostname": null,
"resolver_port": null,
"t": 0.613101
},
{
"answers": null,
"engine": "system",
"failure": "dns_nxdomain_error",
"hostname": "bagongalyansangmakabayan.org",
"query_type": "AAAA",
"resolver_address": "",
"resolver_hostname": null,
"resolver_port": null,
"t": 0.613101
}
],
"requests": null,
"retries": null,
"socksproxy": null,
"status_code_match": null,
"tcp_connect": null,
"title_match": null,
"tls_handshakes": null,
"x_dns_runtime": 613644083,
"x_http_runtime": 3250,
"x_status": 2080,
"x_tcptls_runtime": 50375,
"x_th_runtime": 1320951959
},
"test_name": "web_connectivity",
"test_runtime": 1.934845125,
"test_start_time": "2022-06-23 08:47:36",
"test_version": "0.4.1"
}

Data from Windows:

{
"annotations": {
"architecture": "amd64",
"engine_name": "ooniprobe-engine",
"engine_version": "3.14.1",
"platform": "windows"
},
"data_format_version": "0.2.0",
"input": "https://bagongalyansangmakabayan.org/",
"measurement_start_time": "2022-06-23 08:50:10",
"probe_asn": "AS9299",
"probe_cc": "PH",
"probe_ip": "127.0.0.1",
"probe_network_name": "Philippine Long Distance Telephone Co.",
"report_id": "",
"resolver_asn": "AS13335",
"resolver_ip": "162.158.229.16",
"resolver_network_name": "Cloudflare, Inc.",
"software_name": "ooniprobe-desktop",
"software_version": "3.7.0",
"test_keys": {
"accessible": null,
"agent": "redirect",
"blocking": null,
"body_length_match": null,
"body_proportion": 0,
"client_resolver": "162.158.229.16",
"control": {
"dns": {
"addrs": [],
"failure": "unknown_error"
},
"http_request": {
"body_length": 62242,
"failure": null,
"headers": {
"Alt-Svc": "h3=":443"; ma=2592000, h3-29=":443"; ma=2592000, h3-Q050=":443"; ma=2592000, h3-Q046=":443"; ma=2592000, h3-Q043=":443"; ma=2592000, quic=":443"; ma=2592000; v="43,46"",
"Content-Type": "text/html; charset=UTF-8",
"Date": "Thu, 23 Jun 2022 08:48:15 GMT",
"Link": "https://bagongalyansangmakabayan.org/wp-json/; rel="[https://api.w.org/](https://api.w.org/%5C)"",
"Server": "LiteSpeed",
"Strict-Transport-Security": "max-age=63072000; includeSubDomains",
"X-Content-Type-Options": "nosniff",
"X-Frame-Options": "SAMEORIGIN",
"X-Powered-By": "PHP/7.4.30"
},
"status_code": 200,
"title": "Bagong alyansang makabayan"
},
"tcp_connect": {}
},
"control_failure": null,
"dns_consistency": "inconsistent",
"dns_experiment_failure": "unknown_failure: lookup bagongalyansangmakabayan.org: getaddrinfow: This is usually a temporary error during hostname resolution and means that the local server did not receive a response from an authoritative server.",
"headers_match": null,
"http_experiment_failure": null,
"network_events": null,
"queries": [
{
"answers": null,
"engine": "system",
"failure": "unknown_failure: lookup bagongalyansangmakabayan.org: getaddrinfow: This is usually a temporary error during hostname resolution and means that the local server did not receive a response from an authoritative server.",
"hostname": "bagongalyansangmakabayan.org",
"query_type": "A",
"resolver_address": "",
"resolver_hostname": null,
"resolver_port": null,
"t": 1.1524483
},
{
"answers": null,
"engine": "system",
"failure": "unknown_failure: lookup bagongalyansangmakabayan.org: getaddrinfow: This is usually a temporary error during hostname resolution and means that the local server did not receive a response from an authoritative server.",
"hostname": "bagongalyansangmakabayan.org",
"query_type": "AAAA",
"resolver_address": "",
"resolver_hostname": null,
"resolver_port": null,
"t": 1.1524483
}
],
"requests": null,
"retries": null,
"socksproxy": null,
"status_code_match": null,
"tcp_connect": null,
"title_match": null,
"tls_handshakes": null,
"x_dns_runtime": 1152448300,
"x_http_runtime": 0,
"x_status": 16384,
"x_tcptls_runtime": 0,
"x_th_runtime": 957020200
},
"test_name": "web_connectivity",
"test_runtime": 2.1100237,
"test_start_time": "2022-06-23 08:50:07",
"test_version": "0.4.1"
}

[hellais]

It looks like there is an issue in handling certain types of failures on windows which should have been resolved in more recent versions of probe-engine, but @bassosimone will confirm.