New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add default source #21
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/ooni/test-lists/5h2zQsbSs2ADzpCrZMhWgT3HYPad |
@@ -1,84 +0,0 @@ | |||
// { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This action is now performed within components/submit/EditForm.js
components/submit/EditForm.js
Outdated
@@ -27,7 +27,7 @@ export const EditForm = ({ oldEntry, error, onSubmit, onCancel, layout = 'column | |||
url: formData.get('url'), | |||
category_code: categoryCode, | |||
date_added: oldEntry.date_added ?? today, | |||
source: oldEntry.source ?? '', | |||
source: oldEntry.source !== '' ? oldEntry.source : 'Community Member', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's put this value inside of a constant at the beginning of the file and replace the value with "test-lists.ooni.org contribution"
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🐳
Fixes #19
The submission is created like this.