Fix infinite loop when calling close when auto_reconnect is enabled #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Found it! When calling close it would attempt to reconnect since `auto_reconnect` is set to true by default.
|
Great stuff @Tarangp , added you to the repo. Can we rename |
|
I didn't know what to call it either, I used it because essentially they do the same thing. Of course while optimal it makes it harder to understand. Perhaps |
|
That's fine. Although you probably want to set it to |
|
Yup that should take care of it, so its set to |
tmeasday
added a commit
that referenced
this pull request
Apr 7, 2013
Fix infinite loop when calling close when auto_reconnect is enabled
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #16
Found it! When calling close it would attempt to reconnect since
auto_reconnectis set to true by default.