[PLAYER-4171] Implemented review comments

ooyala · Sep 20, 2018 · 52e6226 · 52e6226
1 parent 6cd9af8
commit 52e6226
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 10 deletions.
diff --git a/FreewheelSampleApp/app/build.gradle b/FreewheelSampleApp/app/build.gradle
@@ -30,20 +30,22 @@ task copyTask(type: Copy) {
 
 tasks.copyTask.execute()
 
+ext.supportLibraryVersion = "27.1.1"
+
 project.configurations.all {
     resolutionStrategy.eachDependency { details ->
         if (details.requested.group == 'com.android.support'
                 && !details.requested.name.contains('multidex')) {
-            details.useVersion "27.1.1"
+            details.useVersion "${supportLibraryVersion}"
         }
     }
 }
 
 dependencies {
     implementation 'com.google.android.gms:play-services-ads:15.0.1'
     implementation 'com.google.android.exoplayer:exoplayer:2.8.3'
-    implementation 'com.android.support:support-v4:27.1.1'
-    implementation 'com.android.support:appcompat-v7:27.1.1'
+    implementation "com.android.support:support-v4:${supportLibraryVersion}"
+    implementation "com.android.support:appcompat-v7:${supportLibraryVersion}"
     implementation files('libs/FWAdManager.jar')
     implementation files('libs/OoyalaFreewheelSDK.jar')
     implementation files('libs/OoyalaSDK.aar')

diff --git a/OoyalaSkinSampleApp/app/build.gradle b/OoyalaSkinSampleApp/app/build.gradle
@@ -80,11 +80,13 @@ repositories {
     }
 }
 
+ext.supportLibraryVersion = "27.1.1"
+
 project.configurations.all {
     resolutionStrategy.eachDependency { details ->
         if (details.requested.group == 'com.android.support'
                 && !details.requested.name.contains('multidex')) {
-            details.useVersion "27.1.1"
+            details.useVersion "${supportLibraryVersion}"
         }
     }
 }
@@ -118,8 +120,8 @@ dependencies {
     implementation 'com.google.android.exoplayer:exoplayer:2.8.3'
     implementation 'com.google.android.gms:play-services-ads:15.0.1'
     implementation 'com.google.ads.interactivemedia.v3:interactivemedia:3.8.5'
-    implementation 'com.android.support:appcompat-v7:27.1.1'
-    implementation 'com.android.support:recyclerview-v7:27.1.1'
+    implementation "com.android.support:appcompat-v7:${supportLibraryVersion}"
+    implementation "com.android.support:recyclerview-v7:${supportLibraryVersion}"
     implementation 'javax.inject:javax.inject:1'
     implementation 'com.android.support:multidex:1.0.3'
     implementation 'com.android.volley:volley:1.1.0'

diff --git a/VRSampleAppKotlin/app/src/main/java/com/ooyala/sample/screen/VideoRecyclerFragment.kt b/VRSampleAppKotlin/app/src/main/java/com/ooyala/sample/screen/VideoRecyclerFragment.kt
@@ -7,7 +7,6 @@ import android.view.LayoutInflater
 import android.view.View
 import android.view.ViewGroup
 import com.ooyala.sample.R
-import com.ooyala.sample.R.id.videoRecyclerView
 import com.ooyala.sample.interfaces.VideoChooseInterface
 import com.ooyala.sample.adapters.VideoRecyclerAdapter
 import com.ooyala.sample.utils.AdList

diff --git a/settings.gradle b/settings.gradle
@@ -62,11 +62,11 @@ project(':HeartbeatSampleApp').projectDir = new File(settingsDir, './HeartbeatSa
 
 // Developer
 //include ':skin'
-//project(':skin').projectDir=new File(settingsDir, '../native-skin/sdk/android/skin/')
+//project(':skin').projectDir = new File(settingsDir, '../native-skin/sdk/android/skin/')
 //include ':core'
-//project(':core').projectDir=new File(settingsDir, '../android-sdk/sdk/core/')
+//project(':core').projectDir = new File(settingsDir, '../android-sdk/sdk/core/')
 //include ':cast'
-//project(':cast').projectDir=new File(settingsDir, '../android-sdk/sdk/cast/')
+//project(':cast').projectDir = new File(settingsDir, '../android-sdk/sdk/cast/')
 //include(':vrsdk')
 //project(':vrsdk').projectDir = new File(settingsDir, '../android-sdk/sdk/vrsdk/')
 //include(':ima')