Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PBW-7936] Audio player not working on Android 9 #356

Merged
merged 1 commit into from May 29, 2019
Merged

Conversation

ipadilla4
Copy link
Contributor

The issue is that when customer accidentally or in purpose adds both main and bitmovin plugin to their implementation, main plugin will try to play audio_hls in cases where it shouldn't have like Android Chrome. This should only be played with Bitmovin plugin.

This fix consists in removing audio_hls supported encoding in Android Chrome.

src/main/js/main_html5.js Outdated Show resolved Hide resolved
src/main/js/main_html5.js Outdated Show resolved Hide resolved
Copy link
Contributor

@zelibobla zelibobla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great finding, @ipadilla4 !

@marcosmx marcosmx self-requested a review May 29, 2019 17:02
@marcosmx marcosmx merged commit 4e8ffce into master May 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants