@types/node is listed as dependency rather than a devDependency

[fde31]

Describe the bug
Not necessarily a bug but I noticed that the @types/node package is listed as production dependency, adding additional bloat to the package. Maybe I missed something, but is it necessary or just an oversight?

Expected behavior
I expect xmlbuilder to only still production relevant dependencies when running npm install --production

Version:

• xmlbuilder2 [2.4.0]

Happy to make a PR for this change but thought I'd check first if there is a specific reason it's not just a devDependency

Thanks

[campionfellin]

Any update here? This is a change I'd like to see as well

[oozcitak]

The reason is that the library exports some node types. For example XMLBuilderCB class is a node EventEmitter. Without @types/node in production dependencies, TypeScript consumers of the package wouldn't see the EventEmitter interface.

Edit: Related #52

[campionfellin]

Would it be possible to use * as the node version instead of 14.6.2?

[oozcitak]

Would it be possible to use * as the node version instead of 14.6.2?

Can you describe why you require this?

[campionfellin]

We're getting conflicting versions of @types/node that seems to be causing issues on Windows machines: projen/projen#498 . You can see that jest uses * as well:

https://github.com/facebook/jest/blob/36d23f5fa145bbcecd7529fa198fe3e26b5e41e3/packages/jest-console/package.json#L18

I think it may also work if you add it as a peerDependency but I am not entirely sure.

[campionfellin]

@oozcitak would you be able to release a new version of xmlbuilder2 please? :)

[oozcitak]

@campionfellin Can you wait till weekend? I'm on a trip for two days.

[campionfellin]

Yes, that's great :) Enjoy your trip! 😎