Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update xmlbuilder2 dependency #635

Closed
wants to merge 1 commit into from

Conversation

campionfellin
Copy link
Contributor

I am hoping that this will fix #498

You can see the diff between the current xmlbuilder2 library and my fork of it here -

oozcitak/xmlbuilder2@master...campionfellin:master

Basically, just changing the dependency on @types/node from 14.6.2 to *

Signed-off-by: campionfellin campionfellin@gmail.com


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Signed-off-by: campionfellin <campionfellin@gmail.com>
@eladb
Copy link
Contributor

eladb commented Mar 24, 2021

@campionfellin isn't it possible to get this updated upstream (i.e. submit a PR against xmlbuilder2) instead of forking? How do we expect to maintain the fork?

Copy link
Contributor

@eladb eladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment

@campionfellin
Copy link
Contributor Author

@eladb it doesn't really seem like xmlbuilder2 is actively maintained, there is this PR from January: oozcitak/xmlbuilder2#69

And there hasn't been a real commit since November - https://github.com/oozcitak/xmlbuilder2/commits/master

@eladb
Copy link
Contributor

eladb commented Mar 24, 2021

I see oozcitak/xmlbuilder2#84 has been raised a few hours ago. Shall we try to ping the maintainer there and see where this goes? Perhaps submit a PR?

@campionfellin
Copy link
Contributor Author

Sure! That works for me

@campionfellin
Copy link
Contributor Author

Looks like a new version of xmlbuilder was released 8 hours ago - https://www.npmjs.com/package/xmlbuilder2

I expect dependabot to make a PR to update sometime within the next 24 hours. Closing this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not working on Windows
2 participants