Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support multiple origin #15

Merged
merged 29 commits into from
Dec 22, 2022
Merged

feat: support multiple origin #15

merged 29 commits into from
Dec 22, 2022

Conversation

xshot9011
Copy link
Contributor

@xshot9011 xshot9011 commented Dec 1, 2022

Submit a pull request 馃殌

Thank you for help us contribute! Please give us more information about this PR.


What 馃槜

Added

  • Add output.cloudfront_distribution_arn
  • Add variables var.name_override, var.origin, var.origin_group and var.origin_access_identities
  • Add locals variables local.empty_prefix, local.empty_environment, local.empty_name and local.raise_empty_name
  • Add attributes dynamic "origin" for all origin in aws_cloudfront_distribution.distribution

Changed

  • Update outputs
    • Rename output.cf_domain_name to output.cloudfront_distribution_domain_name
    • Rename output.cf_s3_iam_arn to cloudfront_origin_access_identities
  • Update local local.resource_name to local.name
  • Update variable description for var.prefix, var.environment and var.name
  • Update resource aws_cloudfront_distribution.distribution code format
  • Update attribute default_cache_behavior; compress, min_ttl, default_ttl, max_ttl in aws_cloudfront_distribution.distribution

Removed

  • Remove files dns.tf, examples/complete/acm.tf, examples/complete/s3.tf, iam.tf and locals.tf
  • Remove variables var.lambda_function_association, var.s3_origin, var.origin_read_timeout, var.custom_header_token, secondary_origin_config and var.origin_config
  • Remove resource aws_cloudfront_origin_access_identity.cloudfront_s3_policy
  • Remove custom_origin_config, dynamic "origin" (s3), dynamic "ordered_cache_behavior" (s3) attribute in aws_cloudfront_distribution.distribution

Why 馃ズ

  • Remove complexity of module
  • Support naming override for some f customer

@xshot9011 xshot9011 marked this pull request as ready for review December 2, 2022 05:00
@xshot9011 xshot9011 requested a review from a team December 2, 2022 05:08
Copy link
Contributor

@artpasut artpasut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@xshot9011 xshot9011 merged commit 76c2e81 into main Dec 22, 2022
@xshot9011 xshot9011 deleted the feat/support-multiple-origin branch December 22, 2022 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants