-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support multiple origin #15
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artpasut
approved these changes
Dec 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submit a pull request 馃殌
Thank you for help us contribute! Please give us more information about this PR.
What 馃槜
Added
output.cloudfront_distribution_arn
var.name_override
,var.origin
,var.origin_group
andvar.origin_access_identities
local.empty_prefix
,local.empty_environment
,local.empty_name
andlocal.raise_empty_name
dynamic "origin"
for all origin inaws_cloudfront_distribution.distribution
Changed
output.cf_domain_name
tooutput.cloudfront_distribution_domain_name
output.cf_s3_iam_arn
tocloudfront_origin_access_identities
local.resource_name
tolocal.name
var.prefix
,var.environment
andvar.name
aws_cloudfront_distribution.distribution
code formatdefault_cache_behavior
;compress
,min_ttl
,default_ttl
,max_ttl
inaws_cloudfront_distribution.distribution
Removed
dns.tf
,examples/complete/acm.tf
,examples/complete/s3.tf
,iam.tf
andlocals.tf
var.lambda_function_association
,var.s3_origin
,var.origin_read_timeout
,var.custom_header_token
,secondary_origin_config
andvar.origin_config
aws_cloudfront_origin_access_identity.cloudfront_s3_policy
custom_origin_config
,dynamic "origin" (s3)
,dynamic "ordered_cache_behavior" (s3)
attribute inaws_cloudfront_distribution.distribution
Why 馃ズ