Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BT-661 (lot) fields.json and schema are in conflict #266

Closed
Havunen opened this issue Dec 7, 2022 · 3 comments
Closed

BT-661 (lot) fields.json and schema are in conflict #266

Havunen opened this issue Dec 7, 2022 · 3 comments
Labels
enhancement New feature or request fields Related to field metadata (/fields/fields.json) schemas Related to eForms Schemas (/schemas SDK folder).

Comments

@Havunen
Copy link
Contributor

Havunen commented Dec 7, 2022

BT-661 (lot) is defined as indicator type in the fields.json

ref: https://github.com/OP-TED/eForms-SDK/blob/develop/fields/fields.json#L16670-L16690

But in the schema this property is defined as TextType array

https://github.com/OP-TED/eForms-SDK/blob/develop/schemas/maindoc/UBL-ContractAwardNotice-2.3.xsd#L61
https://github.com/OP-TED/eForms-SDK/blob/develop/schemas/common/UBL-CommonAggregateComponents-2.3.xsd#L4999-L5001
https://github.com/OP-TED/eForms-SDK/blob/develop/schemas/common/UBL-CommonAggregateComponents-2.3.xsd#L2221 (array minOccurs="0" maxOccurs="unbounded" )

and finally limit description is defined as text type:
https://github.com/OP-TED/eForms-SDK/blob/develop/schemas/common/UBL-CommonBasicComponents-2.3.xsd#L3551-L3555

We were expecting this field to be indicator type in XSD

@Havunen
Copy link
Contributor Author

Havunen commented Dec 7, 2022

Also BT-14 is defined as indicator but is referencing text type

https://github.com/OP-TED/eForms-SDK/blob/develop/fields/fields.json#L3510-L3529

shouldn't this field be code type?

@Havunen
Copy link
Contributor Author

Havunen commented Dec 7, 2022

I found out there is document describing this weird behavior: https://simap.ted.europa.eu/documents/10184/320101/eForms+regulation+vs+Schemas_2/8209153c-9541-4672-9c89-25891137744c

It would be nice to have these documented to the SDK somehow

@YvesJo
Copy link
Contributor

YvesJo commented Jan 18, 2023

There are indeed differences between the Implementing Regulation and the UBL Standard; these have been addressed and integrated into the SDK while considering the requirements imposed by both.
Information also exists in the documentation, if you however consider that some information should be added to the SDK, I then recommend that you preferably develop and share this idea in the discussion channel. Clearly stating the expectations (e.g. format, purpose ...) would increase the probability to have it considered and integrated.
I also close this (non-)issue.
KR

@YvesJo YvesJo closed this as not planned Won't fix, can't repro, duplicate, stale Jan 18, 2023
@YvesJo YvesJo added enhancement New feature or request question fields Related to field metadata (/fields/fields.json) schemas Related to eForms Schemas (/schemas SDK folder). labels Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fields Related to field metadata (/fields/fields.json) schemas Related to eForms Schemas (/schemas SDK folder).
Projects
None yet
Development

No branches or pull requests

2 participants