A fifth composite pull request #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Those are two separate, albeit somehow related features. Node#document=, as name suggests, changes a document of some node using Document.adoptNode. The node is first detached from an old document. Note#initialize_copy allows you to #clone or #dup your Nodes by cloning a DOM node as well. This feature fixes opal#65. Implementing the second one required some minor integration with NativeCachedWrapper. I used a long name for a method changing the native reference variable: `set_native_reference`, kind of mirroring the use of `instance_variable_set`, with a similar semantic: "Don't use this method unless you really know what you are doing". This new feature may somehow conflict with how we use some instance variables: #clone/#dup copies them, but well. It's better to have a standard Ruby way to clone a DOM node than to not have it. There shouldn't be too many bugs, maybe some edge cases with the animation subsystem. We can iron that out later.
This will allow us to compute SHA-family hashes of Buffers (ArrayBuffers), for example Buffers that can be extracted from Files.
elia
approved these changes
Nov 12, 2019
There was a problem hiding this comment.
Sorry for the delay, I missed this completely!
Great work 👍
BTW I don't remember if I already told you, but I've added you as a triage/collaborator, that should give you enough permissions to set labels, assign issues and PRs and stuff like that. If you think would make sense for you to have more permissions let's talk on gitter or via mail 👍
|
Thank you! |
|
@elia Thank you for permissions, they will be useful. I will tidy up the issues right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can we clone a DOM node? Now we can!
This is a fifth composite pull request that encompasses my ongoing work on opal-browser.