Sixth composite pull request #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a few options to $document.create_element, so that it can add classes, id and attributes before dispatching. This commit introduces a subclass selection by a selector. This allows users to create their own subclasses based on any CSS selector. This commit enhances Element.create. Subclasses can now be instantiated with just a syntax like: DOM::Element::Textarea.create. While not adding support for custom elements, it lays groundwork for supporting those (ref. opal#82).
This commit introduces a slight incompatibility, but hopefully
it's a worthy one.
The rationale is that I often tend to write code like:
`DOM { div }.append_to(other_node)` to construct a DOM tree and
append it in one go. When I try to capture the tree, I can't -
I think it makes no sense to return a parent.
Regarding other cases where this is done this way, I would note
jQuery even if some people may say it's an unpopular comparison,
but I want this library to give jQuery users a familiar interface.
Nokogiri has no say about this - it doesn't have {pre,ap}pend_to.
Do note, that it makes no change to << and >> which should
return a parent node.
elia
approved these changes
Oct 31, 2020
|
|
||
| })(); | ||
|
|
||
| } |
There was a problem hiding this comment.
nit: It's better to always have a EOF newline if possible to keep git diffs neat, usually it can be configured in the editor 🤓
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After some break I'm back with new features / bugfixes / modifications to opal-browser.
I think the most important part is a rework of DOM::Element subclassing, allowing for some component-like user code and laying some groundwork for future support of custom elements / web components (#82)