Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix slightly misleading instructions. #22

Merged
merged 4 commits into from
Mar 12, 2014
Merged

Conversation

benjamintanweihao
Copy link
Contributor

I don't think require opal-jquery needs to be required explicitly for the DOM manipulation example. However, Document.ready? should be in there.

I don't think `require opal-jquery` needs to be `require`d explicitly for the DOM manipulation example. However, `Document.ready?` should be in there.
@elia
Copy link
Member

elia commented Mar 11, 2014

opal-jquery is the library that provides Element.find etc. and Document.ready? isn't strictly necessary (e.g. if the script is loaded after the <header> tag)

If you can re-add the require I'll be happy to merge

@benjamintanweihao
Copy link
Contributor Author

Done!

@elia
Copy link
Member

elia commented Mar 11, 2014

Good, there's one last typo, #ready? takes a block, so you need to add the missing do

@benjamintanweihao
Copy link
Contributor Author

Oops, that was embarrassing.

@elia
Copy link
Member

elia commented Mar 12, 2014

Do feel at home, happens to everyone 😉

elia added a commit that referenced this pull request Mar 12, 2014
Fix slightly misleading instructions.
@elia elia merged commit 4ab6077 into opal:master Mar 12, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants