Promise Based Async Support #21

wied03 · 2015-06-03T23:03:08Z

Builds on the Opal 0.8/RSpec 3.1 branch/pull request.

I've updated the README and Changelog to show usage but here is what has changed on a more detailed level:

Added a basic Rake task that wraps the opal:spec test and ensures that we fail when we're supposed to and checks to make sure the right tests failed. This is kind of rudimentary I know, but before this, there was no way to verify that opal-rspec was failing when it should
Async support
- Example group hierarchy
- Pending/skipped within the example
- Before/after each
- Around example
- Test failures show up properly in results instead of uncaught exceptions
Added/organized lots of other specs to try and prevent regression as the async changes were made

wied03 · 2015-06-03T23:07:20Z

@elia - will be happy to squash if you like what you see here. I can also redo the PR if/when the 3.1/0.8 PR is merged in so that it's easier to see just the async changes.

elia · 2015-06-03T23:47:57Z

Let's do it this way: squash the commits on #19 and I'll push it as a new rspec31 branch (or something similar) the this PR can target that branch instead of master and the real diff becomes intelligible. Sounds good?

Browser formatter is the more detailed oriented (as compared to text/rake), so go ahead and include stack traces to ease debugging

* Run_examples hack on example group seems to work now

…summary results reflect failures properly * Clean up puts statements

…irst one for the results, and test for it using the old "should make example fail before async block reached" test

…example should be considered complete * Use that to make skip within an example work

Get descendant example groups working with promises (and share code)

… be consistent

…ne stuff

…match that) * Run_after_example had code that ran after the hooks, so needed to wrap that in promises

… specs with async before(:each) +after(:each) now work

…ks, and after better promise understanding, do a more literal conversion of begins/rescues/ensures to promises

* Got something that works as long as the around block does not fail, need to figure out how to fix that

…tly rather than evaluating it in the group in commit b0a4659, all of these specs can be streamlined

wied03 · 2015-06-04T01:38:07Z

@elia - done

…t submodules + Opal append path

ryanstout · 2015-07-24T20:36:39Z

Any updates on this? I could use this merged if it looks good. Nice work @wied03

elia · 2015-07-24T22:41:59Z

It's next on my list (the whole repo) but needing more than 5min of attention I keep delaying it. 😕

ryanstout · 2015-07-24T22:47:02Z

@elia cool, no rush. Keep up the good work.

wied03 mentioned this pull request Jun 3, 2015

Investigate using Promises for async specs #17

Closed

wied03 added 27 commits June 3, 2015 18:15

Upgrade to RSpec 3.1

ddab9c4

Browser formatter is the more detailed oriented (as compared to text/rake), so go ahead and include stack traces to ease debugging

Merge conflict

6c34695

Replicate problem with test

c413c21

Strip this out, see what we can do with a 'done' approach

b759aa1

Focus on 1 for now

5cdfef7

* Break this out into multiple files

20276b0

* Run_examples hack on example group seems to work now

Less debugging

383b4b9

Remove more debugging junk

1714a01

Inline this to try and make it work properly

40ebd64

Got exception throwing to work properly

a8da786

* Incorporate most of the hooks of the async_example run method, now …

29edf0e

…summary results reflect failures properly * Clean up puts statements

Add ability to skip outside the example

0e3cf9b

Move pending check to proper place in the done scope

1d07e78

Acknowledge that multiple queued up exceptions can happen, grab the f…

7968225

…irst one for the results, and test for it using the old "should make example fail before async block reached" test

Handle skip within an example as long as the done clause is there

4c5cb21

* Provide a way for code outside the example to notify that an async …

f58bac2

…example should be considered complete * Use that to make skip within an example work

Make this work without a done call

90c1959

Once done has been called once, ignore further calls

149e799

Catch around hook problems

b87e173

Got something working for around blocks

fd4a8bf

Directly include these now since our changes are more intrusive anyways

446ed3b

Get descendant example groups working with promises (and share code)

Better method name

85e7ce5

Only preserve/don't raise exceptions if we're in async mode

e6fed17

Test mix of specs

ed4e06f

Have non-async examples return a resolved promise so that arounds can…

bf45e11

… be consistent

Speed up tests

cf3e628

Handle promises returned by the example and avoid having to do the do…

e453252

…ne stuff

wied03 added 20 commits June 3, 2015 19:23

Correct test issues

f0a923d

Ensure an after hit problem fails the test

07a91ce

* Correct issues in after test (we have 13 examples in this file, so …

b1d6e9c

…match that) * Run_after_example had code that ran after the hooks, so needed to wrap that in promises

Tweaked naming on tests, updated Rakefile with expected failures, all…

9987e9b

… specs with async before(:each) +after(:each) now work

Start getting around specs into shape

3935e5b

Deal with around failures

a1a95dd

The outer rescue isn't needed anymore

34b3b61

In order to make maintenance easier, make it easier to add around hoo…

70f46d3

…ks, and after better promise understanding, do a more literal conversion of begins/rescues/ensures to promises

* Remove placeholder method

f1beab2

* Got something that works as long as the around block does not fail, need to figure out how to fix that

Deal with failure before example right

57185f0

Correct expected numbers (our shared context has 10 examples)

cc851a6

Tests all pass

0da59f8

Test scenarios where the around hook skips running an example

6cda29e

Remove all of the debug puts statements

a9835c8

Removed more puts statements

4eaa8de

Ensure synchronous arounds work OK

9ca5863

Now that delay_with_promise was adapted to use the source block direc…

6631bf1

…tly rather than evaluating it in the group in commit b0a4659, all of these specs can be streamlined

Documentation

741b7ed

Comment looks better on github w/ line breaks

5d0362d

Somehow this was versioned

e15014c

wied03 added 3 commits June 3, 2015 20:35

Got lost during the merge process

fdbbb8a

Add more info

295a886

We don't need these in the Gemfile anymore, they are dealt with by gi…

d70d9e1

…t submodules + Opal append path

elia mentioned this pull request Jul 27, 2015

Promise Based Async Support – reprise (thanks to @wied03!) #25

Merged

elia closed this in #25 Jul 28, 2015

wied03 deleted the opal-0.8-other/rspec31_async_subject branch July 29, 2015 19:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Promise Based Async Support #21

Promise Based Async Support #21

wied03 commented Jun 3, 2015

wied03 commented Jun 3, 2015

elia commented Jun 3, 2015

wied03 commented Jun 4, 2015

ryanstout commented Jul 24, 2015

elia commented Jul 24, 2015

ryanstout commented Jul 24, 2015

Promise Based Async Support #21

Promise Based Async Support #21

Conversation

wied03 commented Jun 3, 2015

wied03 commented Jun 3, 2015

elia commented Jun 3, 2015

wied03 commented Jun 4, 2015

ryanstout commented Jul 24, 2015

elia commented Jul 24, 2015

ryanstout commented Jul 24, 2015