Cleanup and compliancy fixes for Array#<=>

opal · Oct 28, 2013 · 23393da · 23393da
1 parent 5fec442
commit 23393da
Showing 1 changed file with 15 additions and 5 deletions.
diff --git a/corelib/array.rb b/corelib/array.rb
@@ -167,17 +167,27 @@ def <<(object)
   end
 
   def <=>(other)
+    if Array === other
+      other = other.to_a
+    elsif other.respond_to? :to_ary
+      other = other.to_ary
+    else
+      return
+    end
+
     %x{
-      if (#{self.hash} === #{other.hash}) {
+      if (#{hash} === #{other.hash}) {
         return 0;
       }
 
-      if (#{self}.length != other.length) {
-        return (#{self}.length > other.length) ? 1 : -1;
+      if (self.length != other.length) {
+        return (self.length > other.length) ? 1 : -1;
       }
 
-      for (var i = 0, length = #{self}.length, tmp; i < length; i++) {
-        if ((tmp = #{`#{self}[i]` <=> `other[i]`}) !== 0) {
+      for (var i = 0, length = self.length; i < length; i++) {
+        var tmp = #{`self[i]` <=> `other[i]`};
+
+        if (tmp !== 0) {
           return tmp;
         }
       }