Allow promises to have multiple then/rescue/always #1263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 Master is already targeting 0.10 but if someone needs it individual commits/PRs can be backported to 0.9 and released in 0.9.1 |
|
If it works I'm fine with it, I just have one request, can you add |
According to the A+ promise specification, "then may be called multiple times on the same promise" -- https://promisesaplus.com/#point-36
jgaskins
force-pushed
the
promise-multiple-thens
branch
from
619e8a4
to
eef5edb
Compare
|
I'm not sure what you mean. You want one that does raise if called multiple times on the same promise? |
|
Yes, alternative bang methods that raise. |
|
What was the reason behind the single-use method again? I've asked this before but I don't remember. |
|
I just personally prefer it that way to avoid bugs in the code when you only want to chain and not add up. |
|
Alrighty, done, but it looks like GitHub diffs are broken at the moment? |
|
I'll merge after they're back. |
meh
added a commit
that referenced
this pull request
Jan 8, 2016
Allow promises to have multiple then/rescue/always
hmdne
pushed a commit
to hmdne/opal
that referenced
this pull request
Jan 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the A+ promise specification, "
thenmay be called multiple times on the same promise". Sincefailandalwaysare justthenwith different success/failure semantics, I added the same functionality to them, as well.@wied03, @meh, and I spoke about supporting this in the past. Last I heard, @meh was still contemplating the change. I probably should've put this in before the 0.9 release, but this PR is backwards-compatible with the current release.