Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort specs files to be consistent #1537

Merged
merged 1 commit into from
Jul 22, 2016
Merged

Sort specs files to be consistent #1537

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions tasks/testing.rake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,14 +58,14 @@ module MSpecSuite

# Filters must be added first
suite_filters = suite == 'opal' ? opalspec_filters : rubyspec_filters
add_specs["#{suite} filters", suite_filters]
add_specs["#{suite} filters", suite_filters.sort]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the way, there's no need to sort spec filters, they can't conflict


if pattern
add_specs["PATTERN=#{pattern}", userspecs]
add_specs["PATTERN=#{pattern}", userspecs.sort]
elsif suite == 'opal'
add_specs['spec/opal', opalspecs]
add_specs['spec/opal', opalspecs.sort]
elsif suite == 'ruby'
add_specs['spec/ruby', rubyspecs]
add_specs['spec/ruby', rubyspecs.sort]
else
warn 'Please provide at lease one of the following environment variables:'
warn 'PATTERN # e.g. PATTERN=spec/ruby/core/numeric/**_spec.rb'
Expand Down