Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Matrix and E2MM modules #1764

Merged
merged 4 commits into from
Mar 20, 2018
Merged

Add Matrix and E2MM modules #1764

merged 4 commits into from
Mar 20, 2018

Conversation

iliabylich
Copy link
Contributor

Closes #1739

13 assertions of 252 from MRI's spec for Matrix are failing.

Unfortunately I can't find any specs for Exception2MessageMapper in MRI or RubySpec, but Matrix class heavily uses it and there's a plenty of tests for it in the TestMatrix

@iliabylich
Copy link
Contributor Author

@elia ping

@elia
Copy link
Member

elia commented Mar 19, 2018

@iliabylich approved on codeclimate ✅

@iliabylich
Copy link
Contributor Author

iliabylich commented Mar 19, 2018

Are you ok with the code? Is it 👍 ?

Copy link
Member

@elia elia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you extract a commit for the Module#extend_object addition? I'd prefer it not to show up in a stdlib/matrix commit during git-blame

@iliabylich
Copy link
Contributor Author

Good catch, fixed!

@elia elia merged commit 462f294 into opal:master Mar 20, 2018
elia added a commit that referenced this pull request Mar 20, 2018
@ggrossetie
Copy link
Member

Thanks again @iliabylich for your amazing work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants