-
-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Matrix and E2MM modules #1764
Conversation
@elia ping |
@iliabylich approved on codeclimate ✅ |
Are you ok with the code? Is it 👍 ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you extract a commit for the Module#extend_object
addition? I'd prefer it not to show up in a stdlib/matrix commit during git-blame
Good catch, fixed! |
Thanks again @iliabylich for your amazing work! |
Closes #1739
13 assertions of 252 from MRI's spec for Matrix are failing.
Unfortunately I can't find any specs for
Exception2MessageMapper
in MRI or RubySpec, butMatrix
class heavily uses it and there's a plenty of tests for it in theTestMatrix