New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ES6 modules + new String #1973
Closed
Closed
ES6 modules + new String #1973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--es6-modules compiler option tests for compiler option
global javascript strict mode
enable ruby/language/super_spec
all strings are |
add task bench:opal_strict
add task bench:opal_strict
Benchmarks:
|
conclusions:
|
Closed
properly simply doesnt work. Either it works for webpack, or it works for the other runners/traditional require, but no way to make it work for both. Solution: integrate js as %x{}, works for everybody.
cleanup some naming fix: one global. prefix was missing
properly simply doesnt work. Either it works for webpack, or it works for the other runners/traditional require, but no way to make it work for both. Solution: integrate js as %x{}, works for everybody.
cleanup some naming fix: one global. prefix was missing
obsolete, Javascript 'boxed' values are to be avoided |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
continue work of #1970
experimental
use
new String
instead of string primitives to support ruby String semantics in "use strict" mode