Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Enumerable#zip #1986

Merged
merged 3 commits into from
Jun 18, 2019
Merged

Fix Enumerable#zip #1986

merged 3 commits into from
Jun 18, 2019

Conversation

kachick
Copy link
Contributor

@kachick kachick commented Jun 8, 2019

No description provided.

elia
elia requested changes Jun 11, 2019
View reviewed changes
opal/corelib/helpers.rb Outdated Show resolved Hide resolved
opal/corelib/array.rb Show resolved Hide resolved
elia
elia approved these changes Jun 14, 2019
View reviewed changes
Copy link
Member

@elia elia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

opal/corelib/array.rb Show resolved Hide resolved
@elia
Copy link
Member

elia commented Jun 14, 2019

Can you please rebase so that CI can re-run? 🙏

@kachick
Copy link
Contributor Author

kachick commented Jun 18, 2019

Sure. Rebased!

@elia elia merged commit 1e08a27 into opal:master Jun 18, 2019
@elia
Copy link
Member

elia commented Jun 18, 2019

Thanks!

@kachick
Copy link
Contributor Author

kachick commented Jun 19, 2019

Thank you!

@kachick kachick deleted the enumerable-zip branch June 19, 2019 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elia elia elia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kachick @elia