Move REPL implementation from bin/ to its own lib/ file + specs #2048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes it makes sense and is more readable.
elia
force-pushed
the
elia/repl-rework
branch
3 times, most recently
from
cf36568
to
62c418b
Compare
elia
force-pushed
the
elia/repl-rework
branch
from
62c418b
to
b1b41bd
Compare
In this case for example ensure is clearly mirroring work done in the
preamble.
def run_input_loop
# on SIGINT lets just return from the loop..
previous_trap = trap('SIGINT') { return }
while (line = readline)
run_line(line)
end
ensure
trap('SIGINT', previous_trap || 'DEFAULT')
end
Also add some specs to ensure it will keep working.
elia
force-pushed
the
elia/repl-rework
branch
from
b1b41bd
to
5f2a26d
Compare
elia
added a commit
that referenced
this pull request
Dec 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The REPL has been living happily within the
exe/dir without specs or anything to check it was still working (but manual tests). It's time to give it the attention it deserves ✅