Add a generic implementation of Kernel#caller and #warn(uplevel:) #2065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elia
force-pushed
the
elia/kernel-caller
branch
from
a72d5f9
to
fbeed54
Compare
elia
added
corelib
feature
nodejs
source-maps
usability
elia
force-pushed
the
elia/kernel-caller
branch
4 times, most recently
from
b1cf493
to
d86c92a
Compare
elia
force-pushed
the
elia/kernel-caller
branch
from
d86c92a
to
88d65a9
Compare
iliabylich
approved these changes
Jan 25, 2020
opal/corelib/kernel.rb
Outdated
| @@ -92,8 +92,13 @@ def at_exit(&block) | |||
|
|
|||
| # Opal does not support #caller, but we stub it as an empty array to not | |||
lib/opal/cli_runners/chrome.rb
Outdated
| if (path.endsWith('/index.js')) { | ||
| return { | ||
| url: './index.map', | ||
| map: #{builder.source_map.to_json.to_json} |
There was a problem hiding this comment.
can the second to_json be replaced with inspect?
There was a problem hiding this comment.
I'm not 100% sure the escaping is the same between the two… I since moved the generation of the values to be written to the top of the method, so the two to_json don't appear one after the other anymore.
This better mirrors ruby.
elia
force-pushed
the
elia/kernel-caller
branch
from
88d65a9
to
5928890
Compare
Move all the file writing to the Ruby side and create a dedicated temporary folder to hold the code. Add a version of the already existing code for sourcemapped stack-traces that works on the browser (via Browserify).
This implementation should be good enough for browsers and node.
elia
force-pushed
the
elia/kernel-caller
branch
from
5928890
to
69952c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Along with the recent changes to the node stacktrace this PR should be making the development experience both of opal itself and of opal apps much better.
Fixes #2068