Enable strict-mode & frozen strings on corelib & stdlib #2075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmdne
reviewed
Jan 14, 2021
We do the (fair, we believe) assumption that everything that comes in is already correctly encoded.
hmdne
force-pushed
the
elia/use-strict-on-corelib
branch
from
aef2532
to
0a29d4d
Compare
Co-authored-by: hmdne <54514036+hmdne@users.noreply.github.com>
Early return if suffix is nil, otherwise convert it to a primitive value before checking it for equality.
This is useful when an AST node is updated but the update is made of already compiled JS fragments.
hmdne
force-pushed
the
elia/use-strict-on-corelib
branch
from
0a29d4d
to
df75b38
Compare
|
I just rebased it onto the current master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.