Move some Opal helpers to the Runtime #2077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elia
force-pushed
the
elia/remove-helpers-special-calls
branch
from
25cb790
to
7bd3108
Compare
elia
force-pushed
the
elia/remove-helpers-special-calls
branch
2 times, most recently
from
68ec09a
to
35f0eda
Compare
elia
force-pushed
the
elia/remove-helpers-special-calls
branch
from
35f0eda
to
d84d225
Compare
When calling super and for better method missing management when the method body is provided we should also have access to the method name.
The last parameter of Opal.find_super_dispatcher wasn't used. It now accepts a boolean that will control if a stub (to support #method_missing) or null should be returned. It also makes use of the new Opal.send2 so that if null is returned because the method is not found and no stub was present (e.g. if the method is only called via __send__) it will correctly call method_missing.
elia
force-pushed
the
elia/remove-helpers-special-calls
branch
from
d84d225
to
c5318c8
Compare
elia
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the most used Opal helpers to the runtime for better performance and to treat them as core (there was some situations in which the helpers were loaded after they were needed).