Implement String#getbyte #2141
Merged
Implement String#getbyte #2141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggrossetie
force-pushed
the
implement-getbyte
branch
from
19b73eb
to
2a52b3c
Compare
ggrossetie
commented
Dec 13, 2020
elia
reviewed
Dec 13, 2020
ggrossetie
force-pushed
the
implement-getbyte
branch
from
a143f65
to
623c869
Compare
ggrossetie
commented
Dec 13, 2020
elia
requested changes
Jan 4, 2021
There was a problem hiding this comment.
Great! One last thing: can you please also remove the definition of getbyte on the base encoding class?
opal/opal/corelib/string/encoding.rb
Lines 59 to 61 in bdbd1bf
|
@elia Done! I've also added a changelog 😉 |
ggrossetie
force-pushed
the
implement-getbyte
branch
from
59ed8e5
to
2c5f2d4
Compare
Also make the implementation of Stirng#bytes rely on #getbyte instead of forwarding to the encoding class which never implemented it.
elia
force-pushed
the
implement-getbyte
branch
from
2c5f2d4
to
a61eac1
Compare
elia
approved these changes
Jan 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #2140