Parser 3.0: methods #2151
Parser 3.0: methods #2151
Conversation
hmdne
force-pushed
the
parser30-methods
branch
from
9f9a45a
to
367fb85
Compare
|
I will need to do a little bit of more work on this. But it seems good enough, of 700 fails added by a version change, this changeset removes 100 of them. |
@hmdne I'm always ok with splitting if you want to have the part of this that's already ok merged right away |
hmdne
force-pushed
the
parser30-methods
branch
from
367fb85
to
2d6312e
Compare
|
@elia If you see a problem to happen since some commit, we can split until that commit. What do you think about the new approach to the #clamp? I basically ported this: https://github.com/ruby/ruby/blob/master/compar.c#L222-L252 (but to Javascript this time) and I found out that the entire module can be simplified. |
|
By the way, this force-push is only changed from f1c0c4f onwards (not counting the squashes). |
On par with Ruby 2.7. This commit rewrites Comparable#clamp to be as close to MRI's cmp_clamp as defined in compar.c. Additionally, there's a refactor done on comparable.rb to simplify it and improve its performance.
elia
force-pushed
the
parser30-methods
branch
from
2d6312e
to
4836fed
Compare
Itself not related to the parser, but implements a few methods that were added between Ruby 2.6 and 3.0.