Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Output Exception#full_message on uncaught exceptions #2269

Merged
merged 1 commit into from Aug 22, 2021
Merged

Output Exception#full_message on uncaught exceptions #2269

merged 1 commit into from Aug 22, 2021

Conversation

hmdne
Copy link
Member

@hmdne hmdne commented Aug 14, 2021

Before:

[user@localhost opal]# bin/opal <<< 'test'
  from -:1:1:in `undefined'
  from /tmp/opal-system-runner-20210814-752381-bplkgc:25233:3:in `null'
  from <js:internal/modules/cjs/loader.js>:1068:30:in `Module._compile'
  from <js:internal/modules/cjs/loader.js>:1097:10:in `Module._extensions..js'
  from <js:internal/modules/cjs/loader.js>:933:32:in `Module.load'
  from <js:internal/modules/cjs/loader.js>:774:14:in `Module._load'
  from <js:internal/modules/run_main.js>:72:12:in `executeUserEntryPoint'

After:

[user@localhost opal]# bin/opal <<< 'test'
-:1:1:in `undefined': undefined method `test' for main (NoMethodError)
	from /tmp/opal-system-runner-20210814-753127-xwfdfg:25233:3:in `null'
	from <js:internal/modules/cjs/loader.js>:1068:30:in `Module._compile'
	from <js:internal/modules/cjs/loader.js>:1097:10:in `Module._extensions..js'
	from <js:internal/modules/cjs/loader.js>:933:32:in `Module.load'
	from <js:internal/modules/cjs/loader.js>:774:14:in `Module._load'
	from <js:internal/modules/run_main.js>:72:12:in `executeUserEntryPoint'
[user@localhost opal]#

@hmdne
Output Exception#full_message on uncaught exceptions
2b088a4 
Before:
```
[user@localhost opal]# bin/opal <<< 'test'
  from -:1:1:in `undefined'
  from /tmp/opal-system-runner-20210814-752381-bplkgc:25233:3:in `null'
  from <js:internal/modules/cjs/loader.js>:1068:30:in `Module._compile'
  from <js:internal/modules/cjs/loader.js>:1097:10:in `Module._extensions..js'
  from <js:internal/modules/cjs/loader.js>:933:32:in `Module.load'
  from <js:internal/modules/cjs/loader.js>:774:14:in `Module._load'
  from <js:internal/modules/run_main.js>:72:12:in `executeUserEntryPoint'
```

After:
```
[user@localhost opal]# bin/opal <<< 'test'
-:1:1:in `undefined': undefined method `test' for main (NoMethodError)
	from /tmp/opal-system-runner-20210814-753127-xwfdfg:25233:3:in `null'
	from <js:internal/modules/cjs/loader.js>:1068:30:in `Module._compile'
	from <js:internal/modules/cjs/loader.js>:1097:10:in `Module._extensions..js'
	from <js:internal/modules/cjs/loader.js>:933:32:in `Module.load'
	from <js:internal/modules/cjs/loader.js>:774:14:in `Module._load'
	from <js:internal/modules/run_main.js>:72:12:in `executeUserEntryPoint'
[user@localhost opal]#
```
@hmdne hmdne added this to the v1.3 milestone Aug 15, 2021
@elia elia merged commit 25dcf2c into master Aug 22, 2021
@elia elia deleted the hmdne/full_message_on_uncaught branch August 22, 2021 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elia elia elia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hmdne @elia