Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exit REPL respecting the exit status number #2396

Merged
merged 1 commit into from Feb 16, 2022
Merged

Exit REPL respecting the exit status number #2396

merged 1 commit into from Feb 16, 2022

Conversation

janbiedermann
Copy link
Member

No description provided.

@janbiedermann
Copy link
Member Author

janbiedermann commented Feb 16, 2022 •
edited

because of:

>> $?.exit
C:/Ruby31-x64/lib/ruby/gems/3.1.0/gems/opal-1.4.1/lib/opal/repl.rb:167:in `rescue in eval_js': undefined method `exitstatus' for nil:NilClass (NoMethodError)

      exit $?.exitstatus
             ^^^^^^^^^^^
        from C:/Ruby31-x64/lib/ruby/gems/3.1.0/gems/opal-1.4.1/lib/opal/repl.rb:153:in `eval_js'
        from C:/Ruby31-x64/lib/ruby/gems/3.1.0/gems/opal-1.4.1/lib/opal/repl.rb:121:in `eval_ruby'
        from C:/Ruby31-x64/lib/ruby/gems/3.1.0/gems/opal-1.4.1/lib/opal/repl.rb:60:in `run_input_loop'
        from C:/Ruby31-x64/lib/ruby/gems/3.1.0/gems/opal-1.4.1/lib/opal/repl.rb:39:in `run'
        from C:/Ruby31-x64/lib/ruby/gems/3.1.0/gems/opal-1.4.1/lib/opal/cli.rb:88:in `run_repl'
        from C:/Ruby31-x64/lib/ruby/gems/3.1.0/gems/opal-1.4.1/lib/opal/cli.rb:69:in `run'
        from C:/Ruby31-x64/lib/ruby/gems/3.1.0/gems/opal-1.4.1/exe/opal:26:in `<top (required)>'
        from C:/Ruby31-x64/bin/opal:25:in `load'
        from C:/Ruby31-x64/bin/opal:25:in `<main>'

@janbiedermann janbiedermann changed the title exit gracefully exit repl gracefully Feb 16, 2022
@hmdne hmdne merged commit bcc27a2 into opal:master Feb 16, 2022
@hmdne
Copy link
Member

hmdne commented Feb 16, 2022

Thanks!

@hmdne hmdne added the stable-backport This PR should be backported to stable versions label Feb 16, 2022
@janbiedermann janbiedermann deleted the exit_gracefully branch March 13, 2022 00:36
@elia elia changed the title exit repl gracefully Exit REPL respecting the exit status number Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
stable-backport This PR should be backported to stable versions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@janbiedermann @hmdne