Server CLIRunner refactor #2436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elia
requested changes
Sep 21, 2022
There was a problem hiding this comment.
Awesome, thoughts on going a step further and always using a dynamic-builder for all runners?
My guess is that the real difference is that some runners will only fetch the builder once, while others will do it multiple times. That way we can avoid some complexity.
This is so that at this time we have a DOM tree ready, so we don't have to explicitly do on(:dom_ready) in order to receive $document.body
elia
force-pushed
the
hmdne/server-runner
branch
from
6104fdc
to
6e74ec6
Compare
elia
approved these changes
Oct 5, 2022
* We change the API here, now the provided builder is a proc that returns a new Builder instance which will always correspond to an up-to-date code. * As a result - now the server runner will supply an up-to-date code each refresh. * Also refactors the Server CLI Runner to use Opal::SimpleServer. * Ensure files are rewinded as they need to be re-read at each refresh
elia
force-pushed
the
hmdne/server-runner
branch
from
6e74ec6
to
ec886e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the Server CLI Runner to use Opal::SimpleServer
provide the runners with a Builder, but a proc that returns a Builder
which will always correspond to an up-to-date code.
each refresh.