New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

String#length should be available when using opal/mini.rb #2438

Merged

elia merged 1 commit into opal:master from dan42:string-length

Oct 5, 2022

Contributor

dan42 commented Sep 28, 2022

So String#length and String#size definition should be moved from string/encoding.rb (which is not loaded by opal/mini.rb) to string.rb


          Move String#length to main string.rb file so it's available when usin…

c985d69

…g opal/mini

hmdne added this to the v1.6 milestone

elia approved these changes

View reviewed changes

Member

elia left a comment

Nice one! Thanks for catching this 👍👍👍

elia merged commit e6a69ca into opal:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment