Windows performance:compare #2450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janbiedermann
force-pushed
the
windows_performance_compare
branch
3 times, most recently
from
1ae9fcd
to
9235af4
Compare
janbiedermann
force-pushed
the
windows_performance_compare
branch
2 times, most recently
from
a58e52c
to
e0dbd6e
Compare
janbiedermann
force-pushed
the
windows_performance_compare
branch
from
e0dbd6e
to
3521e3f
Compare
|
Now ready |
hmdne
force-pushed
the
windows_performance_compare
branch
from
f7a9eac
to
0f480dc
Compare
elia
approved these changes
Oct 26, 2022
There was a problem hiding this comment.
@janbiedermann thanks for this PR! Looks great, just left a couple of comments for minor changes, can you please try them on windows?
Meanwhile I'm pre-approving 👍
| @@ -15,7 +15,7 @@ module Util | |||
| # @param str [String] string to minify | |||
| # @return [String] | |||
| def uglify(source, mangle: false) | |||
| sh "bin/yarn -s run terser -c #{'-m' if mangle}", data: source | |||
| sh "#{'ruby ' if Gem.win_platform?}bin/yarn -s run terser -c #{'-m' if mangle}", data: source | |||
There was a problem hiding this comment.
nit: we might want to use Gem.ruby here, but not necessary
Comment on lines
+3
to
+4
| require_relative "#{__dir__}/../lib/opal/util" | ||
| require_relative "#{__dir__}/../lib/opal/os" |
There was a problem hiding this comment.
nit: the initial "#{__dir__}/ might not be necessary
There was a problem hiding this comment.
I had to use dir so that it would use the patched version
| @@ -1,4 +1,8 @@ | |||
| require_relative "#{__dir__}/../lib/opal/os" | |||
There was a problem hiding this comment.
nit: also here using dir shouldn't be necessary
There was a problem hiding this comment.
I had to use dir so that it would use the patched version
|
@hmdne OS abstraction is working great |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.