Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Opal::BuilderProcessors::RubyERBProcessor #2470

Merged
merged 1 commit into from Nov 17, 2022
Merged

Add Opal::BuilderProcessors::RubyERBProcessor #2470

merged 1 commit into from Nov 17, 2022

Conversation

hmdne
Copy link
Member

@hmdne hmdne commented Nov 15, 2022

No description provided.

@hmdne hmdne added the small label Nov 15, 2022
@hmdne hmdne added this to the v1.6 milestone Nov 15, 2022
@hmdne hmdne force-pushed the hmdne/ruby-erb-processor branch 2 times, most recently from f2d1954 to eb978b2 Compare November 17, 2022 03:21
elia
elia approved these changes Nov 17, 2022
View reviewed changes
Copy link
Member

@elia elia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thoughts on compiling the generated ruby source in the RubyERBProcessor?

@elia elia merged commit 2cfd60d into master Nov 17, 2022
@elia elia deleted the hmdne/ruby-erb-processor branch November 17, 2022 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elia elia elia approved these changes

Assignees
No one assigned
Labels
small
Projects
None yet
Milestone
v1.6
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hmdne @elia