Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Date/Time.parse on Firefox more compatible with Chrome and Ruby #2506

Merged
merged 1 commit into from
Jan 4, 2023
Merged

Make Date/Time.parse on Firefox more compatible with Chrome and Ruby #2506

merged 1 commit into from
Jan 4, 2023

Conversation

janbiedermann
Copy link
Member

@janbiedermann janbiedermann commented Jan 1, 2023 •
edited

Fixes spec:

1)
DateTime.parse(.) parses YYYY.MM.DD into a DateTime object FAILED
Expected NaN == 2007
to be truthy but was false

on Firefox

This was referenced Jan 1, 2023
Merged
Merged
@elia elia merged commit 3226a04 into opal:master Jan 4, 2023
@janbiedermann janbiedermann deleted the foxy_time branch January 5, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elia elia elia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@janbiedermann @elia