Platform specific spec filters #2508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elia
reviewed
Jan 3, 2023
tasks/testing.rake
Outdated
Comment on lines
91
to
93
| platform_filters = [] | ||
| platform_filters = Dir["spec/filters/platform/#{platform}/*.rb"] if Dir.exist?("spec/filters/platform/#{platform}") | ||
| rubyspec_filters = (Dir['spec/filters/bugs/*.rb'] + Dir['spec/filters/unsupported/*.rb'] + platform_filters) - opalspec_filters |
There was a problem hiding this comment.
I think this can be simplified to:
rubyspec_filters = Dir["spec/filters/{unsupported,bugs,platform/#{platform}}/*.rb'] - opalspec_filtersas Dir[] doesn't require a check for existence
janbiedermann
force-pushed
the
platform_filters
branch
from
e866a8a
to
1bb6cc4
Compare
elia
approved these changes
Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
May add
spec/filters/platform/#{platform}/*.rbfilesWill be required by safari runner and #2507