Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While setting up the Chrome runner for opal-rspec, I came across this error message with the builder:
Since the code is using Marshal to pass data through the IO pipe, it expects to be in the ASCII-8BIT encoding. It would make sense then that we set
binmode
on the IO pipes so that they don't get confused with the string encoding.Sorry for not including any tests, since I'm having trouble figuring out exactly what input causes it. It seems to work sometimes with a simple example, but loading more files causes it to crash? I'm not too sure.
I have an example repo here: https://github.com/bgastelo/example-opal-rspec-async where it is occurring. I've stepped through my debugger but I must be missing what causes it.
This is my first PR, so let me know if there is anything I can do to update my PR.
Thanks,
Brandon